fix(lib): esbuild helper functions injection not working with named exports#14539
Merged
bluwy merged 1 commit intovitejs:mainfrom Oct 9, 2023
Merged
Conversation
sapphi-red
added
p3-minor-bug
sapphi-red
commented
Oct 5, 2023
Comment on lines
-28
to
+31
| // IIFE content looks like `var MyLib = function() {`. Spaces are removed when minified | ||
| // IIFE content looks like `var MyLib = function() {`. | ||
| // Spaces are removed and parameters are mangled when minified | ||
| const IIFE_BEGIN_RE = | ||
| /(const|var)\s+\S+\s*=\s*function\(\)\s*\{.*"use strict";/s | ||
| /(const|var)\s+\S+\s*=\s*function\([^()]*\)\s*\{\s*"use strict";/ |
Member
Author
There was a problem hiding this comment.
.* needs to be replaced with \s* otherwise this test will fail.
vite/playground/lib/__tests__/lib.spec.ts
Lines 42 to 49 in 22bd67d
This fix relies on the fact that evanw/esbuild#3322 is fixed. But because that fix landed in 0.19.3, we cannot backport this fix to v4 directly.
We can use /(const|var)\s+\S+\s*=\s*function\([^()]*\)\s*\{[\s\w,;]*"use strict";/ instead of this regex to allow var _a, _b part that might be injected by esbuild. But I guess it's safer to simply revert #14094 for v4.
bluwy
approved these changes
Oct 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a regression caused by #14094
fixes #14537
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).